Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Apply correct fuselage color tokens #27089

Merged
merged 9 commits into from
Oct 18, 2022
Merged

Chore: Apply correct fuselage color tokens #27089

merged 9 commits into from
Oct 18, 2022

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 18, 2022

before we didn't have a well-defined semantic palette and with that several used the wrong values, this pr tries to adjust the vast majority, but still some are missing

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested review from a team as code owners October 18, 2022 03:50
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #27089 (75093fe) into develop (f707ba2) will increase coverage by 0.77%.
The diff coverage is 50.00%.

❗ Current head 75093fe differs from pull request most recent head 7ff3f5d. Consider uploading reports for the commit 7ff3f5d to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27089      +/-   ##
===========================================
+ Coverage    40.20%   40.97%   +0.77%     
===========================================
  Files          827      802      -25     
  Lines        18250    17819     -431     
  Branches      2031     1972      -59     
===========================================
- Hits          7338     7302      -36     
+ Misses       10618    10223     -395     
  Partials       294      294              
Flag Coverage Δ
e2e 40.97% <50.00%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 4cd1280 into develop Oct 18, 2022
@ggazzo ggazzo deleted the chore/fix-layout branch October 18, 2022 12:45
@ggazzo ggazzo mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants